Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-31746) feat(home): add hybrid playlist with recommendation #7060

Merged
merged 7 commits into from
Oct 22, 2024

Conversation

tanguyprache
Copy link
Contributor

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-31746

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident [on Notion][2]

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" [on Notion][1]

Screenshots

delete if no UI change

Platform Mockup/Before After
Desktop - Chrome
Enregistrement.de.l.ecran.2024-10-19.a.11.23.18.mov
Enregistrement.de.l.ecran.2024-10-19.a.11.04.23.mov

Copy link

github-actions bot commented Oct 19, 2024

Performance Comparison Report

Significant Changes To Render Duration

There are no entries

Meaningless Changes To Render Duration

Show entries
Name Render Duration Render Count
Search Landing Page - Performance test for Search Landing page 13.9 ms → 14.1 ms (+0.2 ms, +1.4%) 5 → 5
Performance test for EndedBookings page 30.2 ms → 30.2 ms 6 → 6
Performance test for Venue page 2.7 ms → 2.5 ms (-0.2 ms, -7.4%) 2 → 2
Performance test for Profile page 6.5 ms → 6.2 ms (-0.3 ms, -4.6%) 5 → 5
Search Results - Performance test for Search Results page 14.3 ms → 14.0 ms (-0.3 ms, -2.1%) 5 → 5
Performance test for Bookings page 94.5 ms → 93.4 ms (-1.1 ms, -1.2%) 11 → 11
Performance test for Favorites page 63.5 ms → 62.2 ms (-1.3 ms, -2.0%) 6 → 6
Performance test for Offer page 71.3 ms → 69.6 ms (-1.7 ms, -2.4%) 2 → 2
Show details
Name Render Duration Render Count
Search Landing Page - Performance test for Search Landing page Baseline
Mean: 13.9 ms
Stdev: 1.6 ms (11.5%)
Runs: 16 16 16 14 14 13 13 13 12 12

Current
Mean: 14.1 ms
Stdev: 1.4 ms (10.3%)
Runs: 15 15 15 15 15 15 14 14 12 11
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for EndedBookings page Baseline
Mean: 30.2 ms
Stdev: 1.5 ms (5.1%)
Runs: 33 32 31 31 30 30 29 29 29 28

Current
Mean: 30.2 ms
Stdev: 2.3 ms (7.8%)
Runs: 34 32 32 32 30 30 30 28 27 27
Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Performance test for Venue page Baseline
Mean: 2.7 ms
Stdev: 0.7 ms (25.0%)
Runs: 4 3 3 3 3 3 2 2 2 2

Current
Mean: 2.5 ms
Stdev: 0.8 ms (34.0%)
Runs: 4 4 3 2 2 2 2 2 2 2
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Performance test for Profile page Baseline
Mean: 6.5 ms
Stdev: 1.0 ms (15.0%)
Runs: 8 7 7 7 7 7 6 6 5 5

Current
Mean: 6.2 ms
Stdev: 0.8 ms (12.7%)
Runs: 8 7 6 6 6 6 6 6 6 5
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Search Results - Performance test for Search Results page Baseline
Mean: 14.3 ms
Stdev: 1.1 ms (7.4%)
Runs: 16 15 15 15 14 14 14 14 14 12

Current
Mean: 14.0 ms
Stdev: 1.3 ms (9.5%)
Runs: 17 15 14 14 14 14 14 13 13 12
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Bookings page Baseline
Mean: 94.5 ms
Stdev: 3.6 ms (3.8%)
Runs: 101 99 98 94 93 93 93 92 92 90

Current
Mean: 93.4 ms
Stdev: 3.9 ms (4.1%)
Runs: 98 98 97 96 94 93 91 91 89 87
Baseline
Mean: 11
Stdev: 0 (0.0%)
Runs: 11 11 11 11 11 11 11 11 11 11

Current
Mean: 11
Stdev: 0 (0.0%)
Runs: 11 11 11 11 11 11 11 11 11 11
Performance test for Favorites page Baseline
Mean: 63.5 ms
Stdev: 3.4 ms (5.4%)
Runs: 68 67 67 66 64 63 61 61 60 58

Current
Mean: 62.2 ms
Stdev: 2.4 ms (3.9%)
Runs: 68 63 63 63 62 62 61 61 60 59
Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Performance test for Offer page Baseline
Mean: 71.3 ms
Stdev: 3.5 ms (4.9%)
Runs: 76 75 74 74 71 71 70 69 68 65

Current
Mean: 69.6 ms
Stdev: 1.8 ms (2.6%)
Runs: 73 72 71 70 69 69 68 68 68 68
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2

Changes To Render Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against bdd42d9

Copy link

sonarcloud bot commented Oct 22, 2024

Copy link

sonarcloud bot commented Oct 22, 2024

@nmajorfrances-pass nmajorfrances-pass merged commit a1219fc into master Oct 22, 2024
52 checks passed
@nmajorfrances-pass nmajorfrances-pass deleted the pc-31746/hybrid-reco-playlist branch October 22, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants